-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add line and column numbers to error messages in ktlint. #251
Conversation
LGTM. What error do you get when running tests locally? |
@shyiko Would you be so kind as to review this as well? |
I'd change error message to something simpler (e.g. |
@nedtwigg when running locally i get seems like the resources needed to run the test aren't being picked up from dependencies? i see testlib as a test dependency though. |
Spotless chains a bunch of Feel free to format the line numbers as-is or according to @shyiko's advice, doesn't matter which way to us. I just did |
Ok, I'll format it as-is. We can improve on it later when the need arises. I guess my IDE can't find those resources files, but the tests work fine from the command line. Updated the tests! |
Can you add a link to this PR into the changelog? That helps people review what happened, and helps them see how to make similar changes in the future. |
Fixes #249
Add to release notes
I wasn't able to run tests locally, but before I spend time fixing the tests, I was wondering if this looks good.