Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ktlint FilenameRule #974

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

smpanaro
Copy link
Contributor

@smpanaro smpanaro commented Oct 26, 2021

Passes the filename through to ktlint so that the FilenameRule can run. This rule is in ktlint's standard rule set but was not being enforced.


Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and the build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@smpanaro smpanaro marked this pull request as ready for review October 26, 2021 20:18
@nedtwigg nedtwigg merged commit 4016c91 into diffplug:main Oct 26, 2021
@nedtwigg
Copy link
Member

Released in plugin-gradle 5.17.1 and plugin-maven 2.17.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants