Fix event spamming on GQL dialog events subscription #1165
Assignees
Comments
oskogstad
changed the title
4 tasks
oskogstad
moved this from New issues
to Code Review og PR
in Dialogporten / Arbeidsflate
oskogstad
added a commit
that referenced
this issue
Oct 2, 2024
…ted (#1187) <!--- Provide a general summary of your changes in the Title above --> ## Description Removes limitations on creating DialogUpdatedEvent (They where not created if the only thing changed in the aggregate was added activities) We now create DialogUpdatedEvent for any change in the aggregate. When processing events after a successful DB save we check for either a DialogUpdated or DialogDeleted per dialogID, and notify each dialogEvents GraphQL topic. <!--- Describe your changes in detail --> ## Related Issue(s) - #1165 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced event handling for dialog updates, streamlining the process and reducing redundant event processing. - Introduced a mechanism to prevent multiple sends for the same dialog within a short time frame, improving efficiency. - **Bug Fixes** - Improved logic for processing domain events, ensuring clearer and more efficient handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Magnus Sandgren <5285192+MagnusSandgren@users.noreply.github.com> Co-authored-by: Knut Haug <knut.espen.haug@digdir.no>
oskogstad
changed the title
oskogstad
changed the title
github-project-automation
bot
moved this from Testing / Design QA
to Done
in Dialogporten / Arbeidsflate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in PR #1163 and this comment, consider enhancing the domain event processing in
ConvertDomainEventsToOutboxMessagesInterceptor.csby executing the event handling tasks in parallel to improve performance when processing multiple domain events.Requested by @oskogstad.
The text was updated successfully, but these errors were encountered: