Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Azure Monitor Workspace in our IAC #1462

Open
1 of 2 tasks
Tracked by #1456
arealmaas opened this issue Nov 14, 2024 · 1 comment
Open
1 of 2 tasks
Tracked by #1456

Add an Azure Monitor Workspace in our IAC #1462

arealmaas opened this issue Nov 14, 2024 · 1 comment
Assignees
@arealmaas
Labels
monitoring Issue related to logging and monitoring

Comments

@arealmaas
Copy link
Collaborator

arealmaas commented Nov 14, 2024 •
edited
Loading 

resource monitorWorkspace 'Microsoft.Monitor/monitoringAccounts@2023-03-15' = {
  name: workspaceName
  location: location
  tags: tags
  properties: {
    # You can include additional properties if needed
  }
}

export the workspace id, so we can use that when configuring the container app enviroment.

Tasks
Preview Give feedback
@arealmaas arealmaas mentioned this issue Nov 14, 2024
Open
@arealmaas arealmaas mentioned this issue Nov 18, 2024
Merged
4 tasks
arealmaas added a commit that referenced this issue Nov 19, 2024
@arealmaas @coderabbitai
feat(azure): create azure monitor workspace (#1485)
da0aa8f 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

Adds an azure monitor workspace which will enable us to send metrics to
Prometheus

## Related Issue(s)

- #1462

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a monitoring workspace module for enhanced resource
monitoring capabilities.
- Added a dedicated network security group and subnet for monitoring
purposes.
- **Bug Fixes**
- Improved network configuration without affecting existing setups for
other components.
- **Documentation**
- Updated output sections to include new identifiers for monitoring
resources.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@arealmaas arealmaas added the monitoring Issue related to logging and monitoring label Nov 19, 2024
@arealmaas arealmaas self-assigned this Nov 19, 2024
@arealmaas arealmaas mentioned this issue Nov 19, 2024
Merged
4 tasks
arealmaas added a commit that referenced this issue Nov 19, 2024
@arealmaas
fix(azure): enable public access for azure monitor (#1496)
b0d5794 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

Struggling with connecting to the monitor workspace. Enabling public
access and removing the private dns for now.
#1462

## Related Issue(s)

- #{issue number}

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enabled public network access for the monitoring workspace, allowing
for improved connectivity.

- **Bug Fixes**
- Adjusted the configuration to ensure a reliable connection to the
monitor workspace.

- **Chores**
- Removed parameters related to private networking (`subnetId` and
`vnetId`) from the deployment configuration.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai bot mentioned this issue Nov 21, 2024
Merged
4 tasks
@arealmaas
Copy link
Collaborator Author

After we have been in touch with the Azure team regarding getting metrics from our apps to Azure Monitor Workspace, it seems like it is not possible. Syncing with the Platform team about what we should do. We might not need the Azure Monitor Workspace at all.

@arealmaas arealmaas moved this from Doing to Code Review og PR in Dialogporten / Arbeidsflate Dec 17, 2024
@arealmaas arealmaas mentioned this issue Dec 20, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arealmaas arealmaas

Labels
monitoring Issue related to logging and monitoring
Projects
Dialogporten / Arbeidsflate
Status: Code Review og PR
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arealmaas