Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add process and precedingProcess to dialog as optional fields #1092

Merged
merged 39 commits into from
Sep 11, 2024
Merged

feat: Add process and precedingProcess to dialog as optional fields #1092

merged 39 commits into from
Sep 11, 2024

Conversation

Fargekritt
Copy link
Contributor

@Fargekritt Fargekritt commented Sep 6, 2024 •
edited
Loading

Description

Added process and precedingProcess to dialog with validation to make sure its a valid URI

Related Issue(s)

#565

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@Fargekritt Fargekritt requested a review from a team as a code owner September 6, 2024 17:11
@Fargekritt
Merge branch 'main' into feature/Correlation-mechanism
7ba3ef5 
# Conflicts:
#	src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Migrations/DialogDbContextModelSnapshot.cs
#	src/Digdir.Tool.Dialogporten.GenerateFakeData/DialogGenerator.cs
@Fargekritt
Fixed?
9977007
@Fargekritt
Fixed swagger schema, maybe
25b7dd9
oskogstad
oskogstad requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@oskogstad oskogstad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tittel må følge Conventional Commits

Så for denne vil det bli f.eks. (trimma ned lengden litt og 😇 )
feat: Add process and precedingProcess to dialog as optional fields

Ser det mangler beskrivelse i README.md for dette 🙈
Skal legge til #1093

src/Digdir.Tool.Dialogporten.GenerateFakeData/DialogGenerator.cs Show resolved Hide resolved
src/Digdir.Domain.Dialogporten.WebApi/appsettings.Development.json Outdated Show resolved Hide resolved
...en.Application/Features/V1/ServiceOwner/Dialogs/Queries/Search/SearchDialogQueryValidator.cs Outdated Show resolved Hide resolved
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs Outdated Show resolved Hide resolved
...Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommandValidator.cs Outdated Show resolved Hide resolved
...Application/Features/V1/ServiceOwner/Dialogs/Commands/Create/CreateDialogCommandValidator.cs Outdated Show resolved Hide resolved
...gporten.Application/Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQueryValidator.cs Outdated Show resolved Hide resolved
...ain.Dialogporten.Application/Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQuery.cs Outdated Show resolved Hide resolved
tests/k6/common/dialog.js Outdated Show resolved Hide resolved
tests/k6/tests/enduser/dialogSearch.js Show resolved Hide resolved
@Fargekritt Fargekritt changed the title Added process and precedingProcess to dialog as an optional field feat: Add process and precedingProcess to dialog as optional fields Sep 8, 2024
Fargekritt and others added 9 commits September 8, 2024 11:04
@Fargekritt
default settings
a5a50c1
@Fargekritt @oskogstad
Update tests/k6/common/dialog.js
0937f04 
Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
@Fargekritt @oskogstad
Update src/Digdir.Tool.Dialogporten.GenerateFakeData/DialogGenerator.cs
f1d1cb8 
Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
@Fargekritt @oskogstad
Update src/Digdir.Domain.Dialogporten.Application/Features/V1/Service…
86e9372 
…Owner/Dialogs/Queries/Search/SearchDialogQueryValidator.cs

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
@Fargekritt @oskogstad
Apply suggestions from code review
21c4217 
Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
@Fargekritt
Merge remote-tracking branch 'origin/feature/Correlation-mechanism' i…
ce4dd09 
…nto feature/Correlation-mechanism
@Fargekritt
Cleanup
be818f9
@Fargekritt
Swagger fixed again?
e69d2d1
@Fargekritt
Merge branch 'main' into feature/Correlation-mechanism
ea794dc
@Fargekritt Fargekritt requested a review from oskogstad September 9, 2024 06:41
MagnusSandgren
MagnusSandgren previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@MagnusSandgren MagnusSandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra utgangspunkt! 🎉 Jeg approver PRen, men se over kommentarene mine. Kan være at alle kommentarene mine alt er vurdert. Men dersom de ikke er det og du trenger en ny Approval, si i fra 🙂

...ain.Dialogporten.Application/Features/V1/EndUser/Dialogs/Queries/Search/SearchDialogQuery.cs Outdated Show resolved Hide resolved
...Application/Features/V1/ServiceOwner/Dialogs/Commands/Create/CreateDialogCommandValidator.cs Outdated Show resolved Hide resolved
...Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommandValidator.cs Show resolved Hide resolved
...Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommandValidator.cs Outdated Show resolved Hide resolved
...ialogporten.Application/Features/V1/ServiceOwner/Dialogs/Queries/Search/SearchDialogQuery.cs Outdated Show resolved Hide resolved
...Dialogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogDto.cs Outdated Show resolved Hide resolved
src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/Activities/DialogActivity.cs Show resolved Hide resolved
src/Digdir.Domain.Dialogporten.Domain/Dialogs/Entities/DialogEntity.cs Show resolved Hide resolved
src/Digdir.Domain.Dialogporten.Domain/Dialogs/Events/DialogDomainEventBase.cs Outdated Show resolved Hide resolved
Fargekritt and others added 2 commits September 9, 2024 12:36
@Fargekritt
Fixed test
e20dbc5
@Fargekritt @MagnusSandgren
Apply suggestions from code review
2b17eff 
Co-authored-by: Magnus Sandgren <5285192+MagnusSandgren@users.noreply.github.com>
@Fargekritt
process search made case insensetive
bf19212 
moved process and precedingProcess fields into interface for events
@Fargekritt
Merge remote-tracking branch 'origin/feature/Correlation-mechanism' i…
71b05d6 
…nto feature/Correlation-mechanism
@Fargekritt
fix
c72fa3a
Fargekritt and others added 4 commits September 9, 2024 16:22
@Fargekritt @MagnusSandgren
Apply suggestions from code review
2496369 
Co-authored-by: Magnus Sandgren <5285192+MagnusSandgren@users.noreply.github.com>
@Fargekritt
??
5521ef2
@Fargekritt
removed dupes??
88ed1c4
@Fargekritt
Merge branch 'main' into feature/Correlation-mechanism
8d18288
MagnusSandgren
MagnusSandgren approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@MagnusSandgren MagnusSandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godt jobba! 🥳

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Fargekritt Fargekritt merged commit 2bf0d30 into main Sep 11, 2024
19 of 20 checks passed
@Fargekritt Fargekritt deleted the feature/Correlation-mechanism branch September 11, 2024 11:40
@dialogporten-bot dialogporten-bot mentioned this pull request Sep 11, 2024
Merged
arealmaas pushed a commit that referenced this pull request Sep 16, 2024
@dialogporten-bot
chore(main): release 1.18.0 (#1121)
a014369 
🤖 I have created a release *beep* *boop*
---


##
[1.18.0](v1.17.0...v1.18.0)
(2024-09-16)


### Features

* add dialogOpened activitytype
([#1110](#1110))
([711fa6d](711fa6d))
* Add process and precedingProcess to dialog as optional fields
([#1092](#1092))
([2bf0d30](2bf0d30))


### Bug Fixes

* Allow setting UpdatedAt when creating Dialog
([#1105](#1105))
([481e907](481e907))
* Authorize access to dialog details for any mainresource action
([#1122](#1122))
([a7e769a](a7e769a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knuhau knuhau knuhau left review comments

@oskogstad oskogstad oskogstad approved these changes

@MagnusSandgren MagnusSandgren MagnusSandgren approved these changes

@elsand elsand elsand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Dialogporten / Arbeidsflate
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fargekritt @elsand @MagnusSandgren @oskogstad @knuhau