chore(graphql): revert to old app insights config

[knuhau]

Revert to old app insights config for graphql to fix ApplicationInsightsEventListener.

Summary by CodeRabbit

• New Features

  • Enhanced telemetry capabilities for improved application monitoring.

• Refactor

  • Simplified method signature for application initialization, streamlining the configuration process.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to the application initialization and configuration within Program.cs. The TelemetryConfiguration is now created directly in the logging configuration, simplifying the BuildAndRun method by removing its parameter. The logging setup accesses TelemetryConfiguration from the service provider instead. Additionally, the introduction of the AddApplicationInsightsTelemetry method enhances telemetry capabilities, while error handling remains unchanged.

Changes

File Path	Change Summary
src/Digdir.Domain.Dialogporten.GraphQL/Program.cs	Updated BuildAndRun method signature to remove TelemetryConfiguration parameter; added AddApplicationInsightsTelemetry method for enhanced telemetry setup.

Possibly related PRs

• feat(graphql): configure opentelemetry #1343: This PR modifies the BuildAndRun method in Program.cs to accept a TelemetryConfiguration parameter, which is directly related to the changes made in the main PR that simplifies the method signature by removing this parameter.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e31c08b and 0f900a3.

📒 Files selected for processing (1)

• src/Digdir.Domain.Dialogporten.GraphQL/Program.cs (4 hunks)

🔇 Additional comments (5)

src/Digdir.Domain.Dialogporten.GraphQL/Program.cs (5)

26-26: Bootstrap logger telemetry configuration looks good.

The use of TelemetryConfiguration.CreateDefault() for the bootstrap logger is appropriate since it's only used temporarily during startup.

---

31-31: LGTM! Method call simplified.

The removal of the telemetryConfiguration parameter aligns with the reversion to the previous configuration approach.

---

43-43: Method signature change is consistent.

The simplified signature reduces coupling and aligns with the reversion to the previous configuration approach.

---

79-79: LGTM! Standard Application Insights registration.

The addition of AddApplicationInsightsTelemetry() ensures proper registration of telemetry services and configuration.

---

53-53: Verify TelemetryConfiguration service registration.

While using DI to retrieve TelemetryConfiguration is the correct approach, we should ensure it's properly registered before being resolved.

✅ Verification successful

The search results show that TelemetryConfiguration is being used across multiple services and, more importantly, AddApplicationInsightsTelemetry() is properly registered in the GraphQL project (src/Digdir.Domain.Dialogporten.GraphQL/Program.cs) where the review comment is focused.

Let me generate the final response:

TelemetryConfiguration registration is properly configured

The service registration is verified and properly set up:

• AddApplicationInsightsTelemetry() is called in the GraphQL project, which registers the required TelemetryConfiguration service
• This ensures that GetRequiredService<TelemetryConfiguration>() will work as expected

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for TelemetryConfiguration registration
rg -l "TelemetryConfiguration" | xargs rg "services\..*TelemetryConfiguration"

# Search for AddApplicationInsights calls that might register it
rg "AddApplicationInsights"

Length of output: 1052

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarCloud