Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): ensure gql has maskinporten environment set #1408

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Nov 6, 2024

Description

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration option, "TokenExchangeEnvironment," across multiple environments (development, production, staging, testing, and yt01) to enhance token exchange settings.
  • Bug Fixes

    • Minor formatting adjustments made to the configuration files for improved clarity.

@arealmaas arealmaas requested a review from a team as a code owner November 6, 2024 13:07
Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces a new configuration key, "TokenExchangeEnvironment", across multiple environment-specific JSON files within the appsettings directory. This key is added under the "Maskinporten" section, with different values assigned for development, staging, testing, production, and a specific environment. The existing structure of each JSON file remains unchanged, and no other keys or values are modified.

Changes

File Path Change Summary
src/Digdir.Domain.Dialogporten.GraphQL/appsettings.Development.json Added "TokenExchangeEnvironment": "tt02" under "Maskinporten"
src/Digdir.Domain.Dialogporten.GraphQL/appsettings.prod.json Added "TokenExchangeEnvironment": "prod" under "Maskinporten"
src/Digdir.Domain.Dialogporten.GraphQL/appsettings.staging.json Added "TokenExchangeEnvironment": "tt02" under "Maskinporten"
src/Digdir.Domain.Dialogporten.GraphQL/appsettings.test.json Added "TokenExchangeEnvironment": "tt02" under "Maskinporten"; minor newline formatting change
src/Digdir.Domain.Dialogporten.GraphQL/appsettings.yt01.json Added "TokenExchangeEnvironment": "yt01" under "Maskinporten"

Possibly related PRs

Suggested reviewers

  • knuhau

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Nov 6, 2024

@arealmaas arealmaas merged commit 152417a into main Nov 6, 2024
22 of 23 checks passed
@arealmaas arealmaas deleted the fix/ensure-gql-has-maskinporten-env branch November 6, 2024 13:12
arealmaas pushed a commit that referenced this pull request Nov 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.29.0](v1.28.3...v1.29.0)
(2024-11-06)


### Features

* **webAPI:** Make all lists nullable in OpenAPI schema
([#1359](#1359))
([920d749](920d749))


### Bug Fixes

* **graphql:** ensure gql has maskinporten environment set
([#1408](#1408))
([152417a](152417a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants