chore(graphql): Disable in-memory cache for authorized parties

[oskogstad]

Description

Related Issue(s)

• Subparty forsvinner fra party-response #1226

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

• New Features

  • Enhanced error handling and logging for cache retrieval processes.
  • Introduced a new caching configuration for AuthorizedPartiesResult, optimizing caching strategy with a defined duration.

• Bug Fixes

  • Improved robustness of cache access logic to prevent unhandled exceptions.

• Documentation

  • Updated comments for clarity on logging and caching configurations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces enhancements to the AltinnAuthorizationClient and InfrastructureExtensions classes within the Digdir.Domain.Dialogporten.Infrastructure namespace. Key changes include improved error handling and logging in the AltinnAuthorizationClient, specifically around in-memory cache access, which now includes a try-catch block to log errors effectively. Additionally, the InfrastructureExtensions class receives a new cache configuration for AuthorizedPartiesResult, optimizing its caching strategy without altering existing configurations for other components.

Changes

File Path	Change Summary
src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/AltinnAuthorizationClient.cs	Enhanced error handling and logging for in-memory cache access; added try-catch for reflection logic. Updated logging statements for clarity.
src/Digdir.Domain.Dialogporten.Infrastructure/InfrastructureExtensions.cs	Added new cache configuration for AuthorizedPartiesResult with properties: SkipMemoryCache = true, Duration = 15 minutes, FailSafeMaxDuration = 30 minutes. Comments updated for clarity.

Possibly related PRs

• fix: Add separate settings for parties cache, don't cache invalid response from Altinn 2 #1194: Modifies the AltinnAuthorizationClient to enhance caching mechanisms for authorized parties, directly related to error handling and logging improvements.
• fix: Fallback to using list auth if details auth fails, remove double cache #1274: Involves changes to the AltinnAuthorizationClient focusing on caching strategies and authorization checks, aligning with the main PR's error handling enhancements.
• chore: Temp. disable caching for AuthorizedParties requests #1368: Temporarily disables caching in the GetAuthorizedParties method of the AltinnAuthorizationClient, relevant to the error handling changes.
• fix: Reenable party list cache, log party name look failure with negative cache TTL #1395: Reintroduces caching for the GetAuthorizedParties method in the AltinnAuthorizationClient, connecting to the logging and error handling enhancements.
• chore: Log fusion cache in memory entry #1527: Enhances logging in the GetAuthorizedParties method of the AltinnAuthorizationClient, directly related to the logging improvements in the main PR.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud