-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(webapi): Fix JWTBearerAuth scheme name casing #1578
Conversation
📝 WalkthroughWalkthroughThe pull request introduces significant updates to the OpenAPI specification for the Dialogporten API, including the addition of multiple data schemas and modifications to existing paths and security schemes. A new method for standardizing JWT bearer token casing is added in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (3)
docs/schema/V1/swagger.verified.json
(1 hunks)src/Digdir.Domain.Dialogporten.WebApi/OpenApiDocumentExtensions.cs
(1 hunks)src/Digdir.Domain.Dialogporten.WebApi/Program.cs
(1 hunks)
🔇 Additional comments (3)
src/Digdir.Domain.Dialogporten.WebApi/OpenApiDocumentExtensions.cs (1)
9-15
: Documentation is clear and helpful
The XML documentation clearly explains the purpose of the method and includes the specific error message from BlackDuck that this fix addresses.
src/Digdir.Domain.Dialogporten.WebApi/Program.cs (1)
204-204
: LGTM!
The JWT bearer casing fix is correctly integrated into the Swagger document post-processing pipeline.
docs/schema/V1/swagger.verified.json (1)
4686-4686
: LGTM!
The JWT bearer scheme is correctly set to lowercase "bearer" as required by BlackDuck validation.
Description
Related Issue(s)
Verification
Documentation
docs
-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)