chore: Warning/suppression cleanup in LocalDevelopmentAltinnAuthorization

[oskogstad]

No description provided.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request modifies the LocalDevelopmentAltinnAuthorization class in the src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization directory. Key changes include an updated initialization syntax for the AuthorizedParties list in the GetAuthorizedParties method, while the method signature remains unchanged. Additionally, parameters in the HasListAuthorizationForDialog method have been renamed to indicate they are unused, although the method's functionality continues to return a constant value of true.

Changes

File	Change Summary
src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs	- Updated GetAuthorizedParties method to use a concise object initializer for AuthorizedParties. - Renamed parameters in HasListAuthorizationForDialog from dialog and cancellationToken to _ and __, respectively.

Possibly related PRs

• chore: Temp. disable caching for AuthorizedParties requests #1368: This PR modifies the GetAuthorizedParties method in the AltinnAuthorizationClient class, which is related to the GetAuthorizedParties method in the LocalDevelopmentAltinnAuthorization class from the main PR, indicating a connection in the handling of authorized parties.

Suggested reviewers

• MagnusSandgren

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18990d9 and a538d8e.

📒 Files selected for processing (1)

• src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs (2)

74-74: Consider adding a documentation comment.

Since this is a development implementation that always returns true, it would be helpful to add a documentation comment explaining this behavior to future maintainers.

+    /// <summary>
+    /// Development implementation that always authorizes list access.
+    /// </summary>
     public Task<bool> HasListAuthorizationForDialog(DialogEntity _, CancellationToken __) => Task.FromResult(true);

---

Line range hint 1-14: Add class-level documentation.

Since this is a development implementation that bypasses actual authorization checks, it would be valuable to add class-level documentation explaining its purpose and behavior.

+/// <summary>
+/// Development implementation of IAltinnAuthorization that bypasses actual authorization checks.
+/// This implementation should only be used in local development environments.
+/// </summary>
 internal sealed class LocalDevelopmentAltinnAuthorization : IAltinnAuthorization

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6e88e0c and 18990d9.

📒 Files selected for processing (1)

• src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs (1 hunks)

🔇 Additional comments (1)

src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/LocalDevelopmentAltinnAuthorization.cs (1)

74-74: LGTM! Parameter renaming improves code clarity.

The renaming of unused parameters to _ and __ follows C# conventions and effectively suppresses compiler warnings about unused parameters. This is appropriate for a development implementation.

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE