Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix deployment issues for virtual machine #966

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: fix deployment issues for virtual machine #966

merged 2 commits into from
Aug 6, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Aug 6, 2024 •
edited
Loading

Description

  • Use correct ssh key, directly from github secrets as key vault reference is not supported
  • Remove unnecessary property

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested a review from a team as a code owner August 6, 2024 10:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arealmaas arealmaas mentioned this pull request Aug 6, 2024
Merged
@arealmaas arealmaas merged commit a3ac305 into main Aug 6, 2024
3 checks passed
@arealmaas arealmaas deleted the fix/virtual-machine branch August 6, 2024 13:12
oskogstad added a commit that referenced this pull request Aug 8, 2024
@oskogstad @arealmaas
chore: ensure consistent naming for environment variables for bicep (#…
bc0c28b 
…963)

Dependent on #966

---------

Co-authored-by: Are Almaas <arealmaas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Dialogporten / Arbeidsflate
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arealmaas