Ensure workflow status failure if command fails in backendless mode #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes diggerhq#1658 Error handling in backendless mode was incorrect, resulting in the workflow exit status to be success even if the command execution failed. This patch addresses this issue. The following are some additional notes of this fix: - When `allAppliesSuccessful` is false, we need to call `ReportErrorAndExit()` to ensure that the workflow fails with a non-zero exit status. - Since `ReportErrorAndExit()` invokes `os.Exit()` immediately, it should be called after setting the status of the pull request. - Contrary to intuition, `atLeastOneApply` is counted even if plan command, so we need to use `scheduler.IsPlanJobs()` to determine if the current workflow is plan or apply.
|
I like this change. I am cherry picking for our fork. |
motatoes
approved these changes
Nov 4, 2024
|
Thanks @minamijoyo for this piece! Much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1658
Error handling in backendless mode was incorrect, resulting in the workflow exit status to be success even if the command execution failed. This patch addresses this issue.
The following are some additional notes of this fix:
allAppliesSuccessfulis false, we need to callReportErrorAndExit()to ensure that the workflow fails with a non-zero exit status.ReportErrorAndExit()invokesos.Exit()immediately, it should be called after setting the status of the pull request.atLeastOneApplyis counted even if plan command, so we need to usescheduler.IsPlanJobs()to determine if the current workflow is plan or apply.