Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to build due to Facebook/Meta issue #1039

Closed
gmaclennan opened this issue Nov 7, 2022 · 1 comment · Fixed by #1040
Closed

Failure to build due to Facebook/Meta issue #1039

gmaclennan opened this issue Nov 7, 2022 · 1 comment · Fixed by #1040

Comments

@gmaclennan
Copy link
Member

Since Nov 4th this will fail to build due to facebook/react-native#35210.

Fix coming soon, just need to update to react-native@0.66.5

@gmaclennan
Copy link
Member Author

Ok this is super frustrating. Updating seems to cause react-native-v8 to crash see #1040.

I tried updating react-native-v8 to v1.5.2 (latest) but that seems to be broken right now: Kudo/react-native-v8#149

We can't stick to react-native@0.66.4 because it now fails to build because Facebook published to Maven Central.

Possible ways forward:

  1. Wait for a fix to either RUNTIMEEXECUTOR_LIB set to NOTFOUND Kudo/react-native-v8#149 or crash with null pointer dereference react-native v0.66.5 Kudo/react-native-v8#150
  2. Switch to JSC, remove react-native-v8 from project

(2) would have the impact of potentially higher memory usage on low-end devices that with react-native-v8. Switching ti Hermes would likely have similar benefits to react-native-v8, but Hermes does not fully support Intl (which we use) in v0.66, so we would need to update react-native to v0.70.0.

Possible best way forward: Switch to JSC, accept memory/performance cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant