Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUNTIMEEXECUTOR_LIB set to NOTFOUND #149

Closed
gmaclennan opened this issue Nov 7, 2022 · 6 comments · Fixed by #154
Closed

RUNTIMEEXECUTOR_LIB set to NOTFOUND #149

gmaclennan opened this issue Nov 7, 2022 · 6 comments · Fixed by #154

Comments

@gmaclennan
Copy link

I am using react-native v0.66.5. I just updated to react-native-v8@1.5.2 from react-native-v8@0.66.3-patch.1 (because I was getting a v8 runtime error the update from react-native v0.66.4 to v0.66.5).

I am now getting a build error from gradle:

* What went wrong:
Execution failed for task ':react-native-v8:generateJsonModelDebug'.
> ./node_modules/react-native-v8/android/CMakeLists.txt : C/C++ debug|armeabi-v7a : CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
  Please set them or make sure they are set and tested correctly in the CMake files:
  RUNTIMEEXECUTOR_LIB
      linked by target "v8executor" in directory ./node_modules/react-native-v8/android

Google searches seem to return nothing for RUNTIMEEXECUTOR_LIB, so I'm not sure where to go next.
@gmaclennan
Copy link
Author

In case this is also useful information:

ls -Ral node_modules/react-native/ReactCommon/runtimeexecutor
.rw-r--r--   41 user 26 Oct  1985 .clang-tidy
.rw-r--r--  502 user 26 Oct  1985 Android.mk
.rw-r--r-- 1.4k user 26 Oct  1985 BUCK
.rw-r--r-- 1.4k user 26 Oct  1985 React-runtimeexecutor.podspec
drwxr-xr-x    - user  7 Nov 10:18 ReactCommon/

node_modules/react-native/ReactCommon/runtimeexecutor/ReactCommon:
.rw-r--r-- 3.9k user 26 Oct  1985 RuntimeExecutor.h

@gmaclennan
Copy link
Author

Minimal reproduction here: https://github.com/gmaclennan/RnTest_0_66_5

@gmaclennan
Copy link
Author

Update: I get the same issue with react-native@0.67.5 and react-native-v8@1.5.2

Repo: https://github.com/gmaclennan/RnTest_0_66_5/tree/react-native%400.67.5

This was referenced Nov 7, 2022
Open
Closed
@gmaclennan
Copy link
Author

Further info: In a minimal repro, everything works fine with react-native-v8@1.4.8, so this seems like a recently introduced change likely related to #144 and #145.

@Kudo
Copy link
Owner

Kudo commented Nov 18, 2022

sorry for the breaking change. just notice the runtimeexecutor was not a shared library until react-native 0.68. will have a fix this week.

@Kudo Kudo mentioned this issue Nov 18, 2022
Merged
@Kudo Kudo closed this as completed in #154 Nov 18, 2022
Kudo added a commit that referenced this issue Nov 18, 2022
@Kudo
Fix build error on RN 0.66 and 0.67 (#154)
0b2d09a 
# Why

fix #149 

# How

runtimexecutor is a shared library after rn 0.68. for 0.66 and 0.67, reactnativejni includes the symbols.

# Test Plan

add 0.66 and 0.67 to ci testing
@Kudo
Copy link
Owner

Kudo commented Nov 19, 2022

react-native-v8@1.6.0 includes #154 and should fix the problem for you. thanks for reporting this issue.

@achou11 achou11 mentioned this issue May 31, 2023
Open
@ErikSin ErikSin mentioned this issue Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build error on RN 0.66 and 0.67 Kudo/react-native-v8
2 participants
@Kudo @gmaclennan