-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Fix number fields to always return number not string
- Loading branch information
1 parent
e7a0b3d
commit 01968ca
Showing
4 changed files
with
60 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import React from 'react' | ||
import { TextField as MuiTextField } from '@material-ui/core' | ||
|
||
const TextField = ({ onChange, ...otherProps }) => { | ||
const handleChange = event => | ||
onChange && | ||
onChange( | ||
Number.isNaN(event.target.valueAsNumber) | ||
? undefined | ||
: event.target.valueAsNumber | ||
) | ||
return ( | ||
<MuiTextField | ||
fullWidth | ||
variant="outlined" | ||
margin="normal" | ||
type="number" | ||
InputLabelProps={{ shrink: true }} | ||
onChange={handleChange} | ||
{...otherProps} | ||
/> | ||
) | ||
} | ||
|
||
export default TextField |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import * as React from 'react' | ||
import { action } from '@storybook/addon-actions' | ||
|
||
import NumberField from './NumberField' | ||
|
||
export default { | ||
title: 'ObservationDialog/NumberField' | ||
// decorators: [storyFn => <div style={{ padding: '10px 0' }}>{storyFn()}</div>] | ||
} | ||
|
||
export const defaultStory = () => ( | ||
<NumberField | ||
label="Age" | ||
placeholder="Some placeholder (e.g. example input)" | ||
helperText="The actual question might be here?" | ||
onChange={v => { | ||
console.log(v) | ||
action('onChange')(v) | ||
}} | ||
/> | ||
) | ||
|
||
defaultStory.story = { | ||
name: 'default' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters