fix: fix failing test for converting btween non-string values and labels

digidem · Jul 13, 2020 · 79561db · 79561db
1 parent 20f0257
commit 79561db
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/ObservationDialog/Select.js b/src/ObservationDialog/Select.js
@@ -65,12 +65,12 @@ type Props = {
 function Encoder (options) {
   return {
     toValue: (v) => {
-      var opts = options.find((ops) => ops.label === v)
+      var opts = options.find((ops) => ops.label === v.toString())
       return opts && opts.value || v
     },
     toLabel: (v) => {
       var opts = options.find((ops) => ops.value === v)
-      return opts && opts.label || v
+      return opts && opts.label || v.toString()
     }
   }
 }

diff --git a/src/ObservationDialog/Select.stories.js b/src/ObservationDialog/Select.stories.js
@@ -12,7 +12,7 @@ const countries = [
   { label: 'Andorra' },
   { label: 'Angola' },
   { label: 'Anguilla' },
-  { label: 'Antarctica' },
+  { label: 'Antarctica', value: 1 },
   { label: 'Antigua and Barbuda' },
   { label: 'Argentina' },
   { label: 'Armenia' },
@@ -86,3 +86,16 @@ export const selectMultiple = () => (
     )}
   </StateContainer>
 )
+
+export const selectMultipleNonStringValue= () => (
+  <StateContainer initialValue={[true, 1]}>
+    {(value, setValue) => (
+      <SelectMultiple
+        label="Select Countries"
+        options={countries}
+        value={value}
+        onChange={setValue}
+      />
+    )}
+  </StateContainer>
+)