Remove annoying GCC warning when compiling on Windows.

digit-google · Oct 6, 2023 · f6e83fa · f6e83fa
1 parent 93d0d35
commit f6e83fa
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/disk_interface.cc b/src/disk_interface.cc
@@ -167,8 +167,15 @@ RealDiskInterface::RealDiskInterface()
   HINSTANCE ntdll_lib = ::GetModuleHandleW(L"ntdll");
   if (ntdll_lib) {
     typedef BOOLEAN(WINAPI FunctionType)();
-    auto* func_ptr = reinterpret_cast<FunctionType*>(
-        ::GetProcAddress(ntdll_lib, "RtlAreLongPathsEnabled"));
+    // An intermediate cast to void* is needed to avoid a strange
+    // GCC warning that looks like:
+    //
+    //   warning: cast between incompatible function types from \
+    //   'FARPROC' {aka 'long long int (*)()'} to 'BOOLEAN (*)()' \
+    //  {aka 'unsigned char (*)()'} [-Wcast-function-type]
+    //
+    auto* func_ptr = reinterpret_cast<FunctionType*>(reinterpret_cast<void*>(
+        ::GetProcAddress(ntdll_lib, "RtlAreLongPathsEnabled")));
     if (func_ptr) {
       long_paths_enabled_ = (*func_ptr)();
     }