python: Command hierarchy revamp #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-tanabe
force-pushed
the
python-reduce-dataclass-usage
branch
2 times, most recently
from
05103a5 to
441e7cb
Compare
da-tanabe
force-pushed
the
python-reduce-dataclass-usage
branch
from
441e7cb to
2a7292b
Compare
da-tanabe
changed the title
da-tanabe
force-pushed
the
python-reduce-dataclass-usage
branch
8 times, most recently
from
b28ac34 to
10e4458
Compare
… version and a forward-looking one.
da-tanabe
force-pushed
the
python-reduce-dataclass-usage
branch
from
10e4458 to
c834675
Compare
mschaef-da
approved these changes
Mar 11, 2021
Comment on lines
+479
to
+481
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", DeprecationWarning) | ||
| cb = CommandBuilder.coerce(commands, atomic_default=True) |
There was a problem hiding this comment.
I've said this before, but I think I really like this pattern for managing warnings.
There was a problem hiding this comment.
Agreed—this is something that Python does rather well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python: Prepare the
Commandclasses for the new v8 API (#108).CreateCommand/CreateAndExerciseCommand/ExerciseCommand/ExerciseByKeyCommandfields to match the properties as they exist in the JavaScript ledger bindings (https://docs.daml.com/app-dev/bindings-ts/daml-ledger/classes/_index_.ledger.html).dazl.protocols.commands.*Command, and deprecated counterparts indazl.clients.commands.*Commandthat are meant to help with the v8 transition but will be removed in v9.dataclassinCommand, as dataclasses don't have a particularly straightforward way of deprecating fields.