python: Move PackageLoader into dazl.protocols; make it fully async. #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-tanabe
force-pushed
the
python-move-pkgloader
branch
5 times, most recently
from
ab3acd5 to
d1b0648
Compare
da-tanabe
force-pushed
the
python-move-pkgloader
branch
from
d1b0648 to
cb6fb95
Compare
mschaef-da
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PackageLoader into dazl.protocols; make it fully async.
PackageLoaderfullyasync. The previous version as introduced in python: Introduce SymbolLookup and PackageLoader #142 still used synchronous methods to pull down packages since dazl still used thread-blocking gRPC calls, but in python: Next-gen dazl connection API #108 this will change to gRPC's new native support forasyncio, so thePackageLoaderAPI has to change accordingly.dazl.protocols.pkgloader_aiomodule from python: Next-gen dazl connection API #108 exactly as-is; enough symbols have been moved around to make this file mergeable today.