Re-enable sharing API for recent NC versions #214
Conversation
…ns while keeping the functionality to retrieve a password in any NC version.
|
@aleixq, could you please test this? |
There was a problem hiding this comment.
What did you change here, or was this an accident?
There was a problem hiding this comment.
If yes, can you please remove the change from your commit. 😉
There was a problem hiding this comment.
Git was yelling at me that there were 2 files, crop.svg and Crop.svg. It made this change automatically and I couldn't revert it. So yeah, let's call it an accident
There was a problem hiding this comment.
Could you please remove the change and force push? 😊
There was a problem hiding this comment.
I believe it should be gone now.
There was a problem hiding this comment.
Do you want to squash your commits? Otherwise, I will while merging...
There was a problem hiding this comment.
If you could do it while merging, I'd prefer that. Haven't done it before and chances are I'll break something
There was a problem hiding this comment.
Life got a lot easier when I started using lazygit and learned about fixups.
There was a problem hiding this comment.
https://github.com/jesseduffield/lazygit changed my git-life 😉
Pretty insightful: https://www.youtube.com/watch?v=CPLdltN7wgE&feature=youtu.be
…C versions while keeping the functionality to retrieve a password in any NC version." This reverts commit bb4f0df.
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
|
What I tested:
What's left is to test if the file sharing API works, @aleixq. |
|
Sorry to be late I am on vacation righ tnow. It works! using nextcloud 29.0.2 I would like to keep the class with minimal changes, but redefining the constructor seems a way to make it work, by now... When I get back to work in september I'll try again to claim for a native solution in nextcloud/server side... @DanReiss , your use case must be shown in #197 (comment) ! Just to show to nc server team that allowing fine-tuning of what's exposed (such as filesharing or preview api) will be useful. |
|
Thank you for testing! |
As discussed in #197, here is a PR that addresses the latest share API issues and re-enables sharing for recent NC versions, while keeping the ability to retrieve webapppassword tokens on all NC versions that I have tested.