Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key wrap #36

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Key wrap #36

merged 4 commits into from
Feb 4, 2025

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Feb 3, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 75.95819% with 69 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (870df42) to head (7b04e66).

Files with missing lines Patch % Lines
lib/aeskw.js 67.75% 69 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   94.73%   90.22%   -4.52%     
==========================================
  Files           7        9       +2     
  Lines         950     1217     +267     
==========================================
+ Hits          900     1098     +198     
- Misses         50      119      +69     
Files with missing lines Coverage Δ
lib/asymmetric-key.js 95.19% <100.00%> (+0.16%) ⬆️
lib/config.js 100.00% <100.00%> (ø)
lib/constants.js 100.00% <100.00%> (ø)
lib/helpers.js 100.00% <100.00%> (ø)
lib/index.js 93.46% <100.00%> (+0.01%) ⬆️
lib/key-agreement-key.js 90.78% <100.00%> (+0.40%) ⬆️
lib/logger.js 100.00% <100.00%> (ø)
lib/symmetric-key.js 98.01% <100.00%> (+0.12%) ⬆️
lib/aeskw.js 67.75% <67.75%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870df42...7b04e66. Read the comment docs.

Copy link

@tminard tminard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. I read through carefully and it looks pretty solid to me. I'll take a deeper dive tomorrow.

@dlongley dlongley merged commit f076cc0 into main Feb 4, 2025
4 checks passed
@dlongley dlongley deleted the key-wrap branch February 4, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants