Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coastal module #548

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Update coastal module #548

merged 11 commits into from
Sep 19, 2024

Conversation

vikineema
Copy link
Collaborator

Proposed changes

  • Update coastal module to match updates to pyTMD >= 2.1.5
  • Lint the areaofinterest, bandindices and classification modules

@robbibt
Copy link
Contributor

robbibt commented Sep 19, 2024

Hey @vikineema @mickwelli, just wanted to share a heads-up that we are currently working on moving our tide modelling tools to a new, easier to install package (eo-tides). That will be the place where all our development will be focused on in the future, so we'd love it in the long run if you could switch DE Africa to use that package instead of the coastal.py module here. 🙂 No rush though - this PR looks great, and we won't have the new pacakge ready for a few months - would be great to get your feedback on it when it's available though!

(see discussion here too: GeoscienceAustralia/dea-notebooks#1265)

@vikineema vikineema merged commit 343504c into main Sep 19, 2024
1 check passed
@vikineema vikineema deleted the update-tools branch September 19, 2024 11:25
nanaboamah89 pushed a commit that referenced this pull request Nov 13, 2024
@vikineema
Update coastal module (#548)
996122c 
* Lint the areaofinterest module

* Lint bandindices module

* Lint the classification module

* Lint the coastal module

* Minor edit

* Lint the dask module

* Update model_tides in coastal module

* Update deltat file path

* Bump version

* Set crop parameter default to True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaboamah89 nanaboamah89 nanaboamah89 approved these changes

@mickwelli mickwelli Awaiting requested review from mickwelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikineema @robbibt @nanaboamah89