Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gadm functions public, and tweak type annotations #66

Merged
merged 1 commit into from
Oct 8, 2024
Merged

make gadm functions public, and tweak type annotations #66

merged 1 commit into from
Oct 8, 2024

Conversation

jessjaco
Copy link
Collaborator

@jessjaco jessjaco commented Oct 8, 2024

I use the gadm directly elsewhere

@jessjaco jessjaco requested a review from alexgleith October 8, 2024 20:51
alexgleith
alexgleith approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder if we should use a fancier method of caching the files, but we can firefight that later!

@alexgleith alexgleith merged commit 585d0b5 into main Oct 8, 2024
1 of 2 checks passed
@alexgleith alexgleith deleted the gadm-update branch October 8, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgleith alexgleith alexgleith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessjaco @alexgleith