Fixed table deletion causing bad DROP POLICY statement

Fixes digitallyinduced/thin-backend#69
digitallyinduced · Nov 21, 2022 · c244aa5 · c244aa5
1 parent 395c717
commit c244aa5
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/IHP/IDE/CodeGen/MigrationGenerator.hs b/IHP/IDE/CodeGen/MigrationGenerator.hs
@@ -659,6 +659,7 @@ removeImplicitDeletions actualSchema (statement@dropStatement:rest) | isDropStat
                     )
                 Nothing -> True
         isImplicitlyDeleted (DropConstraint { tableName = constraintTableName }) = constraintTableName /= dropTableName
+        isImplicitlyDeleted (DropPolicy { tableName = policyTableName }) = not (isNothing dropColumnName && policyTableName == dropTableName)
         isImplicitlyDeleted otherwise = True
 
         findIndexByName :: Text -> Maybe Statement

diff --git a/Test/IDE/CodeGeneration/MigrationGenerator.hs b/Test/IDE/CodeGeneration/MigrationGenerator.hs
@@ -1230,6 +1230,25 @@ CREATE POLICY "Users can read and edit their own record" ON public.users USING (
                     DROP POLICY "Users can manage their artefacts" ON artefacts;
                 |]
 
+                diffSchemas targetSchema actualSchema `shouldBe` migration
+
+            it "should not explicitly delete policies when the table is deleted" do
+                -- https://github.com/digitallyinduced/thin-backend/issues/69
+                let actualSchema = sql $ cs [plain|
+                    CREATE TABLE tests (
+                        id UUID DEFAULT uuid_generate_v4() PRIMARY KEY NOT NULL,
+                        user_id UUID DEFAULT ihp_user_id() NOT NULL
+                    );
+                    CREATE INDEX tests_user_id_index ON tests (user_id);
+                    ALTER TABLE tests ADD CONSTRAINT tests_ref_user_id FOREIGN KEY (user_id) REFERENCES users (id) ON DELETE NO ACTION;
+                    ALTER TABLE tests ENABLE ROW LEVEL SECURITY;
+                    CREATE POLICY "Users can manage their tests" ON tests USING (user_id = ihp_user_id()) WITH CHECK (user_id = ihp_user_id());
+                |]
+                let targetSchema = []
+                let migration = sql [i|
+                    DROP TABLE tests;
+                |]
+
                 diffSchemas targetSchema actualSchema `shouldBe` migration
 sql :: Text -> [Statement]
 sql code = case Megaparsec.runParser Parser.parseDDL "" code of