Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashes in html/xml attribute names break hsx parsing #343

Closed
themmes opened this issue Aug 19, 2020 · 0 comments · Fixed by #345
Closed

dashes in html/xml attribute names break hsx parsing #343

themmes opened this issue Aug 19, 2020 · 0 comments · Fixed by #345

Comments

@themmes
Copy link
Collaborator

themmes commented Aug 19, 2020

For example fill-rule="" in the following piece of SVG, breaks the parser

...
  <path fill-rule="evenodd" d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0zM8.5 4a.5.5 0 0 0-1 0v3.5H4a.5.5 0 0 0 0 1h3.5V12a.5.5 0 0 0 1 0V8.5H12a.5.5 0 0 0 0-1H8.5V4z"/>
</svg>
mpscholten added a commit that referenced this issue Aug 21, 2020
@mpscholten
HSX attribute names are now parsed differently for improved error mes…
6a16caa 
…sages

We also added lots of svg attribute names to the attribute name whitelist.
Fixes #343.
@mpscholten mpscholten mentioned this issue Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HSX attribute names are now parsed differently for improved error mes… digitallyinduced/ihp
1 participant
@themmes