Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bounds for ihp-hsx package #1500

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Updated bounds for ihp-hsx package #1500

merged 2 commits into from
Aug 31, 2022

Conversation

mpscholten
Copy link
Member

Possible fix for #1499

Copy link
Contributor

@billksun billksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relaxing the bounds for base seems to do the trick, I can now compile on GHC 9.2.4. But I made some additional comments on things that seem odd to me.

, blaze-markup >= 0.8.2 && < 0.9
, megaparsec >= 9.0.1 && < 9.3
, ghc >= 9.2.4 && < 9.3
, megaparsec >= 9.2.1 && < 9.3
, string-conversions >= 0.4.0 && < 0.5
, ghc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra ghc declared

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that's a copy paste mistake on my side 👍

ihp-hsx/ihp-hsx.cabal Show resolved Hide resolved
Copy link
Contributor

@billksun billksun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mpscholten mpscholten merged commit b7f856d into master Aug 31, 2022
@mpscholten mpscholten deleted the ihp-hsx-bounds branch August 31, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants