Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup without token for offline commands such as app spec validation #67

Closed
CBielstein opened this issue Apr 11, 2023 · 0 comments · Fixed by digitalocean/doctl#1450 or #79
Closed

Comments

@CBielstein
Copy link

Hey DigitalOcean folks!

I use this action in both my continuous integration (PR) and continuous deployment (merged) workflows. For merge, I use it to trigger deployment of my App Platform app after running tests. For my pre-PR CI run, I use it to validate the app spec before merge.

This has been working really well for my own private use, but I've recently opened my repository for other contributors. Contributors are forking the repository and submitting PRs, which attempt to validate the app spec. But since actions from forks don't have access to secrets, the login is failing and I can't validate the spec.

I've played with the doctl CLI on my own machine and it appears spec validation doctl apps spec validate does not require authentication to run.

So what I'm wondering is if it'd be possible to modify this action (I'd be happy to submit a PR for it, if appropriate) to make the token optional. This would allow offline behaviors, such as app spec validation, to be run without exposing secrets to open source collaborators.

In my use case, this would look something like the following:

      - name: Install doctl
        uses: digitalocean/action-doctl@v2

      - name: Validate app spec
        run: doctl apps spec validate .do/app.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant