Replaces gauges with constmetrics #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diffs
changed the title
diffs
deleted the
digitalocean/STORSYS-524/replaces-gauges-with-constmetrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the prometheus gauges to ConstMetrics will help address the issue of some metrics being at wrong values (eg. ceph_pg_state).
Addresses issue #102
Not all gauges have been moved to ConstMetrics in health.go - the ones related to OSD mapping stayed as gauges. This is because existing logic and unit tests need them initialized at 0 and then updated based on certain flags, which is more difficult to do when using ConstMetrics.