Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support storageclass from annotations #149

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

mo-rieger
Copy link
Contributor

@mo-rieger mo-rieger commented Aug 9, 2022

support specifying storage-class via volume.beta.kubernetes.io/storage-class annotation

CLOSES #150

@mo-rieger mo-rieger marked this pull request as draft August 9, 2022 15:29
@mo-rieger mo-rieger marked this pull request as ready for review August 9, 2022 18:45
Copy link
Contributor

@dylanrhysscott dylanrhysscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just added a minor code nit up to you if you want to change it :)

checks/doks/dobs_pod_owner_test.go Show resolved Hide resolved
@mo-rieger mo-rieger merged commit 40b8be2 into master Aug 11, 2022
@mo-rieger mo-rieger deleted the mrieger/storage-class-from-annotations branch August 11, 2022 11:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should be able to retrieve storageClassName from annotation
3 participants