Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook-replacement: ensure that the webhook rules are applicable to v1, apps/* #99

Merged
merged 1 commit into from
Nov 5, 2020
Merged

webhook-replacement: ensure that the webhook rules are applicable to v1, apps/* #99

merged 1 commit into from
Nov 5, 2020

Conversation

varshavaradarajan
Copy link
Collaborator

fixes #93

adamwg
adamwg approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

checks.md Outdated Show resolved Hide resolved
@varshavaradarajan varshavaradarajan merged commit ba1db6a into digitalocean:master Nov 5, 2020
@varshavaradarajan varshavaradarajan deleted the varsha/webhook-check-update branch November 5, 2020 22:22
@adamwg adamwg mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg adamwg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admission control webhook check should check apiGroups
2 participants
@varshavaradarajan @adamwg