Use a enum to represent resource type

digitalocean · Mar 22, 2016 · 960a9c9 · 960a9c9
1 parent a294b44
commit 960a9c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/tags.go b/tags.go
@@ -26,10 +26,17 @@ type TagsServiceOp struct {
 
 var _ TagsService = &TagsServiceOp{}
 
-// Resource represent a single resource for associating/dissociating with tags
+// ResourceType represents a class of resource, currently only droplet are supported
+type ResourceType string
+
+const (
+	DropletResourceType ResourceType = "droplet"
+)
+
+// Resource represent a single resource for associating/disassociating with tags
 type Resource struct {
-	ID   string `json:"resource_id,omit_empty"`
-	Type string `json:"resource_type,omit_empty"`
+	ID   string       `json:"resource_id,omit_empty"`
+	Type ResourceType `json:"resource_type,omit_empty"`
 }
 
 // TaggedResources represent the set of resources a tag is attached to

diff --git a/tags_test.go b/tags_test.go
@@ -330,7 +330,7 @@ func TestTags_TagResource(t *testing.T) {
 	defer teardown()
 
 	tagResourcesRequest := &TagResourcesRequest{
-		Resources: []Resource{{ID: "1", Type: "droplet"}},
+		Resources: []Resource{{ID: "1", Type: DropletResourceType}},
 	}
 
 	mux.HandleFunc("/v2/tags/testing-1/resources", func(w http.ResponseWriter, r *http.Request) {
@@ -359,7 +359,7 @@ func TestTags_UntagResource(t *testing.T) {
 	defer teardown()
 
 	untagResourcesRequest := &UntagResourcesRequest{
-		Resources: []Resource{{ID: "1", Type: "droplet"}},
+		Resources: []Resource{{ID: "1", Type: DropletResourceType}},
 	}
 
 	mux.HandleFunc("/v2/tags/testing-1/resources", func(w http.ResponseWriter, r *http.Request) {