storage: support for beta storage API #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aybabtme
force-pushed
the
beta-storage-blockstore
branch
from
9508915 to
ee84e31
Compare
aybabtme
force-pushed
the
beta-storage-blockstore
branch
from
ee84e31 to
290653f
Compare
This was referenced Jun 2, 2016
Closed
|
🙇 |
aybabtme
force-pushed
the
beta-storage-blockstore
branch
2 times, most recently
from
47742e9 to
790a926
Compare
aybabtme
force-pushed
the
beta-storage-blockstore
branch
7 times, most recently
from
f8ff283 to
39ac4f1
Compare
aybabtme
force-pushed
the
beta-storage-blockstore
branch
from
39ac4f1 to
979e3b3
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for block storage.
note: snapshots are still WIP/beta/unstable, and thus to link against this code, you need to get out of your way and type-assert the Beta features. I think that's a fair compromise, I'm open to alternatives or straight up just deleting the snapshot code.