Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work #2

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

v-ctiutiu
Copy link
Contributor

Overview

Changes made in this PR:

  • Initial documentation about how to deploy and test the operator.
  • Main logic (implemented using Python) to add/change/remove static routes.
  • Sample manifests for testing.

@guardrails
Copy link

guardrails bot commented Sep 2, 2022

⚠️ We detected 3 security issues in this pull request:

Insecure Configuration (1)
Docs Details
💡 Title: hostNetwork is exposed, Severity: Medium

More info on how to fix Insecure Configuration in Kubernetes.


Insecure Access Control (2)
Docs Details
💡 Title: DROP All Capabilities, Severity: Low
File: operator/operator-daemonset.yaml
💡 Title: Containers With Added Capabilities, Severity: Medium

More info on how to fix Insecure Access Control in Kubernetes.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@bikram20
Copy link
Collaborator

bikram20 commented Sep 2, 2022

@v-ctiutiu Nice work! Does the operator need hostNetwork: true?

@v-ctiutiu
Copy link
Contributor Author

@v-ctiutiu Nice work! Does the operator need hostNetwork: true?

Yes, it doesn't work without that setting. The reason is that it needs access to host network to alter static routes. The operator runs in a Docker container after all, hence it runs in an isolated network from the main host.

Hope it makes sense. Thanks.

@bikram20 bikram20 merged commit 2e2b395 into digitalocean:main Sep 2, 2022
@bikram20
Copy link
Collaborator

bikram20 commented Sep 2, 2022

Got it. Thanks.

@v-ctiutiu v-ctiutiu deleted the v-ctiutiu/initial_version branch September 12, 2022 11:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants