Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project consolidation initiative - Phase 3 #7

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Project consolidation initiative - Phase 3 #7

merged 2 commits into from
Sep 13, 2022

Conversation

v-ctiutiu
Copy link
Contributor

@v-ctiutiu v-ctiutiu commented Sep 12, 2022 •
edited
Loading

Overview

Part of #3.

Notable changes in this PR:

  • Do not allow setting the default gateway (possible dangerous operation).
  • Refactored and improved operator logic.
  • Makefile improvements (inject docker image release version in operator DaemonSet).
  • Moved sample manifests to the examples folder.

@guardrails
Copy link

guardrails bot commented Sep 12, 2022

⚠️ We detected 1 security issue in this pull request:

Insecure Access Control (1)
Docs Details
💡 Title: DROP All Capabilities, Severity: Low
File: controller/config/manager.yaml

More info on how to fix Insecure Access Control in Kubernetes.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@v-ctiutiu v-ctiutiu mentioned this pull request Sep 12, 2022
Open
@v-ctiutiu v-ctiutiu merged commit 8e81823 into digitalocean:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bikram20 bikram20 Awaiting requested review from bikram20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v-ctiutiu