Address last couple of comments and add some recent dev changes

digitalocean · Dec 16, 2024 · afa3e30 · afa3e30
1 parent 112cb8a
commit afa3e30
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 9 deletions.
diff --git a/specification/DigitalOcean-public.v2.yaml b/specification/DigitalOcean-public.v2.yaml
@@ -230,9 +230,7 @@ tags:
 
   - name: Droplet Autoscale Pools
     description: |-
-      Autoscaling for Droplets manages horizontal scaling for your applications based on resource usage or a static configuration.
-      When you use autoscaling, you create one or more autoscaling pools. An autoscaling pool has 2 components: scaling configuration, which determines how the pool scales up and down, 
-      and a Droplet template, which defines the configuration of the Droplets in the pool.
+      Droplet autoscale pools manage automatic horizontal scaling for your applications based on resource usage (CPU, memory, or both) or a static configuration.
 
   - name: Firewalls
     description: |-

diff --git a/specification/resources/autoscale_pools/autoscale_pool_list.yml b/specification/resources/autoscale_pools/autoscale_pool_list.yml
@@ -13,6 +13,7 @@ tags:
 parameters:
   - $ref: '../../shared/parameters.yml#/per_page'
   - $ref: '../../shared/parameters.yml#/page'
+  - $ref: './parameters.yml#/autoscale_pool_name'
 
 responses:
   '200':

diff --git a/specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml b/specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml
@@ -65,12 +65,12 @@ properties:
 
   project_id:
     type: string
-    description: The project that the Droplets in the autoscaling pool will belong to.
+    description: The project that the Droplets in the autoscale pool will belong to.
     example: 746c6152-2fa2-11ed-92d3-27aaa54e4988
 
   ipv6:
     type: boolean
-    description: Assigns a unique IPv6 address to each of the Droplets in the autoscaling pool.
+    description: Assigns a unique IPv6 address to each of the Droplets in the autoscale pool.
     example: true
 
   user_data:

diff --git a/specification/resources/autoscale_pools/models/autoscale_pool_dynamic_config.yml b/specification/resources/autoscale_pools/models/autoscale_pool_dynamic_config.yml
@@ -5,27 +5,27 @@ properties:
     type: integer
     example: 5
     description: The minimum number of Droplets in an autoscale pool.
-    minimum: 0
+    minimum: 1
     maximum: 500
   max_instances:
     type: integer
     example: 10
     description: The maximum number of Droplets in an autoscale pool.
-    minimum: 0
+    minimum: 1
     maximum: 1000
   target_cpu_utilization:
     type: number
     format: float
     example: 0.6
     description: Target CPU utilization as a decimal.
-    minimum: 0
+    minimum: 0.05
     maximum: 1
   target_memory_utilization:
     type: number
     format: float
     example: 0.6
     description: Target memory utilization as a decimal.
-    minimum: 0
+    minimum: 0.05
     maximum: 1
   cooldown_minutes:
     type: integer

diff --git a/specification/resources/autoscale_pools/parameters.yml b/specification/resources/autoscale_pools/parameters.yml
@@ -15,3 +15,10 @@ x_dangerous:
     type: boolean
   example: true
   required: true
+autoscale_pool_name:
+  name: name
+  in: query
+  description: The name of the autoscale pool
+  schema:
+    type: string
+  example: my-autoscale-pool