Add lint target to Makefile. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotchneat
reviewed
Jul 17, 2020
Makefile
Outdated
|
|
||
| .PHONY: lint | ||
| lint: ## Lint the OpenAPI spec using Spectral | ||
| spectral lint ${SPEC_FILE} |
There was a problem hiding this comment.
This command assumes we have spectral already installed. Should we add installation instructions or another target to install tools like this?
There was a problem hiding this comment.
I added a package.json file. It's also possible that this is just a distraction at this point, but this seems to work.
There was a problem hiding this comment.
I can't disagree. It's always tough to balance valuable feedback and distractions.
There was a problem hiding this comment.
Meant the PR itself rather than the feedback. That's always appreciated!
andrewsomething
force-pushed
the
make-lint
branch
from
e4229d4 to
39805e6
Compare
andrewsomething
force-pushed
the
make-lint
branch
from
39805e6 to
35687bb
Compare
scotchneat
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the Makefile, it should be the main entry point for the development workflow.