Bump python-dotenv from 0.19.1 to 0.19.2 in /webapp #353
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/pip/webapp/python-dotenv-0.19.2
branch
2 times, most recently
from
a658cc2 to
da7dec9
Compare
Bumps [python-dotenv](https://github.com/theskumar/python-dotenv) from 0.19.1 to 0.19.2. - [Release notes](https://github.com/theskumar/python-dotenv/releases) - [Changelog](https://github.com/theskumar/python-dotenv/blob/master/CHANGELOG.md) - [Commits](theskumar/python-dotenv@v0.19.1...v0.19.2) --- updated-dependencies: - dependency-name: python-dotenv dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/pip/webapp/python-dotenv-0.19.2
branch
from
da7dec9 to
c4a7731
Compare
|
Similarly to #351 this also adds WTForms 3.0. Because the new version changes the fields a lot, I had to adapt how they are imported and adapt some of our own fields |
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| class DecimalOnly: | |||
| def __call__(self, form, field): | |||
| if not field.data.isdecimal(): | |||
| if field.data and not field.data.isdecimal(): | |||
There was a problem hiding this comment.
The StringField will now set the data to None if nothing was provided. In the old version this was an empty string. We needed to change the DecimalOnly validator because of that. Before, we would not accept an empty string as decimalOnly. However, this could have meant an implicit inputRequired. Therefore, I have changed it.
Do you think that is correct or should we test explicitly for None?
There was a problem hiding this comment.
No, I think this is great.
There was a problem hiding this comment.
That worries me a little bit, if we check somewhere for "" but not for None. This also affects the string validators, date validators and probably others where we don't explicitly validate on InputRequired or on None.
There was a problem hiding this comment.
Great point. I had another look.
StringField
We use the StringField only for the SteuerlotseStringField. I have checked all the validators that we use with that field. These are InputRequired and validators.length. Both can work with None.
Fields that inherit from SteuerlotseStringField are the following. The fields marked with * check if data is None in the pre_process method and change it accordingly. I would say that those do not lead to any problems. For the others I described what I checked:
- IdNrField *
- LegacyIdNrField *
- TaxNumberField *
- UnlockCodeField *
- SteuerlotseIbanField: This does not get an error because the data is changed while being processed (s. fields.py l. 116 and StringField's process_formdata). Nevertheless, I have adapted the validator ValidIBan.
- SteuerlotseNameStringField: Does not use any special validators
- SteuerlotseNumericStringField: Uses DecimalOnly which has been adapted.
Besides the StringField we use these fields RadioField, Field, BooleanField, DateField, SelectField, IntegerField. I had a look into their inheritance tree and none of them inherits from the StringField.
Our validators
Although they should not receive None, I have changed the following validators to check for None:
- ValidUnlockCode
- ValidElsterCharacterSet
- ValidUnlockCodeCharacterSet
I would not change the following because they all work with split fields and those should already process None correctly:
- ValidTaxNumberLength
- ValidHessenTaxNumber
- ValidTaxNumber
- ValidIdNr
- IntegerLength and NoZero: Do already work with None.
JulianRoesner
requested review from
a team and
SannyNguyenHung
and removed request for
a team
JulianRoesner
requested review from
frederike-ramin
and removed request for
nfelger
|
I had a look at the WTForms changelog for v. 3.0. including the alpha version. The main part that has been changed is the StringField, the dropped support for Python version < 3.6 ( does not affect us) and that HTML5 widgets are now used by default. Besides that ValueErrors raised in validators are now raised as normal exceptions. They should be exchanged with ValidationErrors. I have added that change. All the other changes seem to fix broken functionality or add new one. |
|
Kudos, SonarCloud Quality Gate passed!
|
Bumps python-dotenv from 0.19.1 to 0.19.2.
Release notes
Sourced from python-dotenv's releases.
Changelog
Sourced from python-dotenv's changelog.
Commits
2471a5aRelease version 0.19.245848bbAdd missing trailing newline when adding new valueDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)