Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari baseline bug for entries fields #98

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

JulianRoesner
Copy link

Short Description

The delete entry button was not aligned in Safari (s. this ticket). In Safari align-items uses bottom border from empty input fields. Using an empty placeholder text as discussed here fixes this issue.

Changes

  • Add a new Mixin, which can be used to set the placeholder text in widgets.
  • Set the placeholder text also in the jquery_entries.html because the entries fields are set there

Feedback

  • Do you have any better idea how to set the placeholder for the entries field than the added macro?

Copy link
Member

@frederike-ramin frederike-ramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the macro fix, actually. Makes the entries field a lot cleaner imo.
Just one thing: I'm not sure SafariBaselineBugFixMixin is the right name as Safari as well as Firefox have this bug. So I'd probably just go for BaselineBugFixMixin instead.

@JulianRoesner JulianRoesner merged commit 39d58f0 into main Aug 10, 2021
@JulianRoesner JulianRoesner deleted the safari_steuermindern branch August 10, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants