Data mount #28
Merged
Data mount #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
sbulage
reviewed
Jul 22, 2019
miqsel/server.py
Outdated
| mount_dir = self.cfg["container"]["data_dir"] | ||
|
|
||
| if mount_dir != "None": | ||
| kwargs.update({"volumes": {mount_dir: {"bind": "/usr/tmp", "mode": "ro"}}}) |
There was a problem hiding this comment.
Strongly Suggest use either /tmp or /var/tmp
There was a problem hiding this comment.
/tmp in heavy container used for creating temp files and .x11 stuff. so its not valid.
about /var/tmp we can use but I think its sharing same like /urs/tmp right?
There was a problem hiding this comment.
Yes. @digitronik you are right, so instead of /usr/tmp use directly /var/tmp.
| @@ -41,5 +41,8 @@ def config(): | |||
| cfg["container"]["server_port"] = click.prompt( | |||
| "Selenium server running on port?", default=cfg["container"]["server_port"] | |||
| ) | |||
| cfg["container"]["data_dir"] = click.prompt( | |||
| "Extra data mount directory to '/urs/tmp'", default=cfg["container"]["data_dir"] | |||
| ) | |||
There was a problem hiding this comment.
Typo:
'/urs/tmp' should be '/usr/tmp'
Signed-off-by: Nikhil Dhandre <ndhandre@redhat.com>
|
@ganeshhubale @sbulage done |
sbulage
approved these changes
Jul 23, 2019
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra data mount
It will help to mount testing pages in selenium server