Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix: Issue #286] Do not populate terraform schema Default field if property type is list #287

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

dikhan
Copy link
Owner

@dikhan dikhan commented Apr 6, 2021

What problem does this Pull Request solve?

Terraform currently does not support setting up Default values for TypeList. Otherwise an error will be thrown by Terraform on runtime like this: Default is not valid for lists

Please link to the issue number here (issue will be closed when PR is merged): Closes #286

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • New feature (change that adds new functionality)
  • Bug-fix (change that fixes current functionality)
  • Tech debt (enhances the current functionality)
  • New release (pumps the version)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have made sure code compiles correctly and all tests are passing by running make test-all
  • I have added/updated necessary documentation (if appropriate)
  • I have added the following info to the title of the PR (pick the appropriate option for the type of change). This is important because the release notes will include this information.
    • Feature Request: PRs related to feature requests should have in the title [FeatureRequest: Issue #X] <PR Title>
    • Bug Fixes: PRs related to bug fixes should have in the title [BugFix: Issue #X] <PR Title>
    • Tech Debt: PRs related to technical debt should have in the title [TechDebt: Issue #X] <PR Title>
    • New Release: PRs related to a new release should have in the title [NewRelease] vX.Y.Z

Checklist for Admins

  • Label is populated
  • PR is assigned to the corresponding project
  • PR has at least 1 reviewer and 1 assignee

@dikhan dikhan added the bug-fix label Apr 6, 2021
@dikhan dikhan requested a review from jzafran April 6, 2021 23:58
@dikhan dikhan self-assigned this Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #287 (a469e4e) into master (1cefe94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          60       60           
  Lines        3065     3066    +1     
=======================================
+ Hits         2824     2825    +1     
  Misses        163      163           
  Partials       78       78           
Impacted Files Coverage Δ
...penapi_spec_resource_schema_definition_property.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cefe94...a469e4e. Read the comment docs.

- Terraform currently does not support setting up Default values for TypeList. Otherwise
an error will be thrown by Terraform on runtime like this: Default is not valid for lists
@dikhan dikhan force-pushed the dont-set-default-to-list branch from 0cb503c to a469e4e Compare April 7, 2021 00:07
@dikhan dikhan merged commit f5efde6 into master Apr 7, 2021
@dikhan dikhan deleted the dont-set-default-to-list branch April 7, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not populate Default field in Terraform schema for properties that are TypeList
2 participants