[BugFix: Issue #334] Fix make test all #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a real domain - Modified the tests to create a pretty random domain to avoid collision with a real domain
This will import the indirect dependency and solve the issues with hc-install package deps
This was referenced Apr 9, 2022
Closed
…lighty - Updated the regex to make it work also in travis ci. For the ref, the error thrown from travis looks like this (note the extra info about the Ip: on 169.254.169.254:53) Error: request POST https://www.endpoint-that-does-not-exist.com/v1/cdns HTTP/1.1 failed. Response Error: 'Post "https://www.endpoint-that-does-not-exist.com/v1/cdns": dial tcp: lookup www.endpoint-that-does-not-exist.com on 169.254.169.254:53: no such host'
…der-openapi into fix-make-test-all
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 60 60
Lines 3584 3584
=======================================
Hits 3357 3357
Misses 160 160
Partials 67 67 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this Pull Request solve?
Please link to the issue number here (issue will be closed when PR is merged): Closes #334
If you don't have an issue created, please create the issue first describing the problem and then open the PR
Type of change
What type of change does your code introduce to the provider? Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:Test output
make test-allis working again:test-all.txt
Checklist
Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:make test-all[FeatureRequest: Issue #X] <PR Title>[BugFix: Issue #X] <PR Title>[TechDebt: Issue #X] <PR Title>[NewRelease] vX.Y.ZChecklist for Admins