Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version update v3 #342

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Major version update v3 #342

merged 1 commit into from
Apr 19, 2022

Conversation

dikhan
Copy link
Owner

@dikhan dikhan commented Apr 19, 2022

What problem does this Pull Request solve?

These PR adds necessary changes to upgrade the repo to major release v3 including:

  • Added major release docs
  • Updated go mod version to v3 as well as the corresponding import paths
  • build and goreleaser build static flags updated to new version
  • updated docsgenerator lib with new v3 imports

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • New feature (change that adds new functionality)
  • Bug-fix (change that fixes current functionality)
  • Tech debt (enhances the current functionality)
  • New release (pumps the version)
  • Preparation for major release

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have made sure code compiles correctly and all tests are passing by running make test-all
  • I have added/updated necessary documentation (if appropriate)
  • [N/A] I have added the following info to the title of the PR (pick the appropriate option for the type of change). This is important because the release notes will include this information.
    • Feature Request: PRs related to feature requests should have in the title [FeatureRequest: Issue #X] <PR Title>
    • Bug Fixes: PRs related to bug fixes should have in the title [BugFix: Issue #X] <PR Title>
    • Tech Debt: PRs related to technical debt should have in the title [TechDebt: Issue #X] <PR Title>
    • New Release: PRs related to a new release should have in the title [NewRelease] vX.Y.Z

Checklist for Admins

  • Label is populated
  • PR is assigned to the corresponding project
  • PR has at least 1 reviewer and 1 assignee

- Added major release docs
- Updated go mod version to v3 as well as the corresponding import paths
- build and goreleaser build static flags updated to new version
- updated docsgenerator lib with new v3 imports
@dikhan dikhan self-assigned this Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #342 (c03dadb) into master (eca9bbd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          60       60           
  Lines        3584     3584           
=======================================
  Hits         3357     3357           
  Misses        160      160           
  Partials       67       67           
Impacted Files Coverage Δ
main.go 34.78% <ø> (ø)
openapi/common.go 90.80% <ø> (ø)
openapi/openapi_client.go 86.29% <ø> (ø)
openapi/openapi_spec_header.go 100.00% <ø> (ø)
...penapi_spec_resource_schema_definition_property.go 100.00% <ø> (ø)
.../openapi_spec_security_definition_apikey_header.go 100.00% <ø> (ø)
...i_spec_security_definition_apikey_header_bearer.go 100.00% <ø> (ø)
...i/openapi_spec_security_definition_apikey_query.go 100.00% <ø> (ø)
...pi_spec_security_definition_apikey_query_bearer.go 100.00% <ø> (ø)
...i_spec_security_definition_apikey_refresh_token.go 84.61% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca9bbd...c03dadb. Read the comment docs.

@dikhan dikhan merged commit 6e56bdc into master Apr 19, 2022
@dikhan dikhan deleted the major-version-upgrade-v3 branch April 19, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant