feat: Override CRA paths #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Sorry for the delay, I've been super busy. I'll be taking a look at open PRs hopefully by next week. |
dilanx
approved these changes
Mar 4, 2023
|
Good feature, and implementation looks good to me. I'll release it with 7.1.0 and will plan to document it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Had to recreate it)
We needed a way to override CRAs appHtml paths and some others in our monorepo, so I've created a way to override any of the default CRA path strings. I saw that this is already requested in several issues (#104 seems to be the main one, still open ones are #414 and maybe #481) and even a PR was made that was closed eventually.
The method of overriding the path config follows the same logic as the other features of the package, you can either pass an object containing the definitions or specify a function that returns them.
After the new path values are set, the context paths also get overridden, for the sake of consistency.