Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Elm 0.19 #60

Merged
merged 50 commits into from
Aug 23, 2018
Merged

Update for Elm 0.19 #60

merged 50 commits into from
Aug 23, 2018

Conversation

xtian
Copy link
Contributor

@xtian xtian commented May 11, 2018

The elm-community packages aren't updated for 0.19 yet, so I wasn't able to resolve all the compiler errors (and since I couldn't compile, I wasn't able to build the generated code), but I made as much progress as I could. Hope this is useful! :)

@xtian xtian force-pushed the elm@0.19 branch 3 times, most recently from 2517094 to ba1f68e Compare May 11, 2018 15:27
@dillonkearns
Copy link
Owner

@xtian thank you so much for the PR! That's awesome that you did this! I am also going to rename the package to elm-graphql with the 0.19 migration, so I will have to make those changes in here as well.

package.json Outdated
"elm-live": "^2.7.5",
"elm-webpack-loader": "^4.3.1",
"elm-test": "^0.18.12",
"elm-webpack-loader": "git+ssh://git@github.com/xtian/elm-webpack-loader.git#0.19",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dillonkearns dillonkearns force-pushed the master branch 2 times, most recently from 0241578 to a3f5d0c Compare July 2, 2018 20:14
@xtian xtian force-pushed the elm@0.19 branch 3 times, most recently from f103928 to 6608903 Compare August 12, 2018 22:07
@xtian
Copy link
Contributor Author

xtian commented Aug 12, 2018

@dillonkearns Got everything compiling, but there are test failures now. I can dig into them in a little bit.

@xtian xtian force-pushed the elm@0.19 branch 6 times, most recently from 0205a17 to f099709 Compare August 12, 2018 23:05
@xtian xtian force-pushed the elm@0.19 branch 7 times, most recently from 1ef0a00 to 02f61a4 Compare August 22, 2018 23:58
@dillonkearns dillonkearns merged commit 54145a6 into dillonkearns:master Aug 23, 2018
@xtian xtian deleted the elm@0.19 branch August 24, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants