Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to elm-codegen 5.0.0 #488

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

miniBill
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for elm-pages-todos ready!

Name Link
🔨 Latest commit b282003
🔍 Latest deploy log https://app.netlify.com/sites/elm-pages-todos/deploys/66f35dad75ef200008e86117
😎 Deploy Preview https://deploy-preview-488--elm-pages-todos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dillonkearns
Copy link
Owner

Thank you for the PR! Looks like there is still some code that isn't compiling from those build failures?

@miniBill
Copy link
Contributor Author

I will look into it!

@miniBill
Copy link
Contributor Author

miniBill commented Aug 29, 2024

I'm having an issue with Scaffold.Route > userFunction > viewFn, in the Nothing case.

You're currently wrapping it. In the call field it seems the objective is to ignore what (in the Just branch) is the Model. But then in callFrom you ignore a different parameter, so I'm confused.

EDIT: figured out how to do it with the new API

@miniBill
Copy link
Contributor Author

(Force pushed to force the CI to run again, as it had a transient error)

@dillonkearns dillonkearns merged commit 5654b80 into dillonkearns:master Sep 25, 2024
9 checks passed
@miniBill miniBill deleted the elm-codegen-5 branch September 25, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants