Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache table & database #77

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkangia
Copy link
Contributor

@mkangia mkangia commented Nov 13, 2024

A safe change to speed up processing for dataset changes.
We should not need to find the db and then the table for every request.

Deployed on staging to test.
Might need to add tests in the code though.

@mkangia mkangia force-pushed the mk/cache-table-db-for-dataset-changes branch from 7704d16 to 678392f Compare November 13, 2024 13:08
@Charl1996
Copy link
Contributor

This is great!

I'm curious to know if you've done some performance comparisons at (some) scale? Not necessary, just curious to see the difference in performance.

@mkangia
Copy link
Contributor Author

mkangia commented Nov 13, 2024

Hey @Charl1996

I have not done any performance testing on this.
The inspiration comes from celery logs showing that they are running tasks in seconds (in range 5-60 seconds) at times, which isn't expected.
This will however just reduce one query to find the database but at scale even that would matter.
Just in case if we get celery monitoring on datadog, before this is released, we will able to see the difference if we have a metric for tasks running time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants