Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt for username & password before they are needed #193

Merged
merged 1 commit into from
Aug 6, 2021
Merged

prompt for username & password before they are needed #193

merged 1 commit into from
Aug 6, 2021

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented Aug 6, 2021 •
edited by mkangia
Loading

https://dimagi-dev.atlassian.net/browse/SAAS-12490

Get the username and password from the user before they are used to create the API client.

@snopoke snopoke requested a review from mkangia August 6, 2021 08:05
mkangia
mkangia approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@mkangia mkangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thank you.

Just confirming if is from the ticket that was submitted for the issue where cli wasn't working with prompts because that was marked as done recently or you just fixed it?
Can you add description?

@snopoke
Copy link
Contributor Author

snopoke commented Aug 6, 2021

Interesting. Thank you.

Just confirming if is from the ticket that was submitted for the issue where cli wasn't working with prompts because that was marked as done recently or you just fixed it?

Yes, it's from that ticket: https://dimagi-dev.atlassian.net/browse/SAAS-12490

@snopoke snopoke merged commit d43db47 into master Aug 6, 2021
@snopoke snopoke deleted the sk/username-password-prompt branch August 6, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkangia mkangia mkangia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snopoke @mkangia