Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize case and form API #24393

Merged
merged 3 commits into from
May 24, 2019
Merged

standardize case and form API #24393

merged 3 commits into from
May 24, 2019

Conversation

snopoke
Copy link
Contributor

@snopoke snopoke commented May 23, 2019

Main driving factor was to get the indexed_on filter working for case API. This was supposed to be done here: #22252 but only applied to Form API.

@snopoke snopoke added the product/all-users-all-environments Change impacts all users on all environments label May 23, 2019
@snopoke snopoke mentioned this pull request May 23, 2019
Closed
esoergel
esoergel approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@esoergel esoergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! It looks like it maintains backwards compatibility too, is that correct?

@snopoke
Copy link
Contributor Author

snopoke commented May 24, 2019

@esoergel it should be, both pieces of code were doing very similar things

@snopoke snopoke merged commit 400354b into master May 24, 2019
@snopoke snopoke deleted the sk/api-indexed-on branch May 24, 2019 13:24
This was referenced May 24, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esoergel esoergel esoergel approved these changes

@Rohit25negi Rohit25negi Awaiting requested review from Rohit25negi

Assignees
No one assigned
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snopoke @esoergel