-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable _all field for sms index #26515
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably OK for ICDS (we have 20M docs). One concern is that we haven't done an ES reindex in a long time so may need to tweak it. We can try kick off the reindex in a limited release and see how it goes.
For future reindexes it would be great to figure out the process for using the ES reindex feature: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/docs-reindex.html
….test_instantiate_all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but @snopoke I approve your changes. Let me know if you want me to delay, otherwise I'll probably merge this tomorrow (Jan 30)
@dannyroberts please can we wait to merge this until the ICDS reindex is complete otherwise it will block deploy. I'm going to continue monitoring it today and hopefully it will be done by EOD. |
@dannyroberts we can go ahead and merge this now |
Awesome, thanks! |
SUMMARY
Amended @snopoke's commit from #25666 to include only SMS index and to update the index name to trigger a reindex.
On production I think the SMS index is small enough that it reindexing isn't a huge burden. Is that true on ICDS as well?