Removed XFormServerModifiedParams

[orangejenny]

@snopoke @sravfeyn This looks like it exists to support this query. Would it be safe to merge this after dimagi/commcare-export#159 or do we need to keep it for the sake of backwards compatibility?

[sravfeyn]

Hey @orangejenny Yes, I remember that's mostly from DTE. But you could do a quick grep on nginx logs to be 100%sure.

[snopoke]

I expect we'd need to keep it for some time since it will take a while for all clients to be upgraded

[snopoke]

When we do remove it we should add an error message as well so that DET users know what to do to fix it.

[orangejenny]

@sravfeyn @snopoke Sounds good, thanks. I'll leave this open and revisit in a while.

[snopoke]

A quick data pull of our logs shows this query is still being used by a number of domains. I see commcare-export versions 1.8.1 (latest), 1.4.0, 1.2.1. I think removing this will require forcing upgrades and re-syncing of data which may not be tractable for some large domains.

I think we could come up with a way to seamlessly migrate to the new pagination style but we'll still need to force an upgrade of commcare-export. I've made an issue for that here: dimagi/commcare-export#220

[orangejenny]

@snopoke Realistically I'm unlikely to take this forward. Would it make sense to go in USH's tech debt backlog?

[snopoke]

@snopoke Realistically I'm unlikely to take this forward. Would it make sense to go in USH's tech debt backlog?

I think we can just punt it. I've created the issue in the commcare-export repo so it won't get lost.